Skip to content

✨Computational backend: persist cancellation request #6694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 11, 2024
Merged

✨Computational backend: persist cancellation request #6694

merged 10 commits into from
Nov 11, 2024

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented Nov 8, 2024 •
edited
Loading

What do these changes do?

This PR persists computational job cancellation requests in the DB as a time of the request.
E.g.: when a computational job is marked for cancellation it was only known to the current instance of the director-v2. Therefore if it would restart this information would be lost. This is now fixed.

Driving test: test_handling_cancellation_of_jobs_after_reboot

This might help with #6400

Related issue/s

How to test

Dev-ops checklist

@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label Nov 8, 2024
@sanderegg sanderegg added this to the Event Horizon milestone Nov 8, 2024
@sanderegg sanderegg self-assigned this Nov 8, 2024
@codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.23%. Comparing base (1564d50) to head (1f981f9).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6694      +/-   ##
==========================================
+ Coverage   87.95%   89.23%   +1.27%     
==========================================
  Files        1569     1349     -220     
  Lines       63110    55089    -8021     
  Branches     2106      979    -1127     
==========================================
- Hits        55507    49156    -6351     
+ Misses       7278     5778    -1500     
+ Partials      325      155     -170
Flag Coverage Δ
integrationtests 64.86% <100.00%> (+0.03%) ⬆️
unittests 86.90% <100.00%> (+0.98%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.20% <ø> (ø)
pkg_notifications_library 83.79% <ø> (ø)
pkg_postgres_database 87.77% <ø> (ø)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.27% <ø> (ø)
agent 97.17% <ø> (ø)
api_server 89.82% <ø> (ø)
autoscaling 95.21% <ø> (ø)
catalog 89.46% <ø> (ø)
clusters_keeper 98.72% <ø> (ø)
dask_sidecar 91.32% <ø> (ø)
datcore_adapter 94.05% <ø> (ø)
director 58.38% <ø> (-0.05%) ⬇️
director_v2 90.84% <100.00%> (+<0.01%) ⬆️
dynamic_scheduler 96.59% <ø> (ø)
dynamic_sidecar 89.82% <ø> (+0.03%) ⬆️
efs_guardian 90.00% <ø> (ø)
invitations 93.51% <ø> (ø)
osparc_gateway_server 85.41% <ø> (ø)
payments 93.02% <ø> (ø)
resource_usage_tracker 90.75% <ø> (ø)
storage 89.76% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 89.36% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1564d50...1f981f9. Read the comment docs.

@sanderegg sanderegg marked this pull request as ready for review November 8, 2024 16:39
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

matusdrobuliak66
matusdrobuliak66 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sanderegg sanderegg merged commit e32787b into ITISFoundation:master Nov 11, 2024
89 checks passed
@sanderegg sanderegg deleted the computational-backend/keep-cancellation-in-db branch November 11, 2024 07:44
This was referenced Nov 11, 2024
Closed
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jan 15, 2025
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo

Assignees

@sanderegg sanderegg

Labels

a:director-v2 issue related with the director-v2 service

Projects

None yet

Milestone

Event Horizon

Development

Successfully merging this pull request may close these issues.

3 participants

@sanderegg @GitHK @matusdrobuliak66